Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various variable inits #5101

Merged
merged 3 commits into from Mar 5, 2019

Conversation

Projects
None yet
3 participants
@moneromooo-monero
Copy link
Contributor

moneromooo-monero commented Jan 28, 2019

No description provided.

@moneromooo-monero moneromooo-monero changed the title Init Various variable inits Jan 28, 2019

@fluffypony

This comment has been minimized.

Copy link
Collaborator

fluffypony commented Mar 4, 2019

@moneromooo-monero please rebase

@vtnerd

vtnerd approved these changes Mar 4, 2019

Copy link
Contributor

vtnerd left a comment

Good technique for eliminating alot of the possible uninitialized values issues in the RPC system without having to re-engineer everything.

@moneromooo-monero moneromooo-monero force-pushed the moneromooo-monero:init branch from 33d8b7b to da13086 Mar 4, 2019

@moneromooo-monero

This comment has been minimized.

Copy link
Contributor Author

moneromooo-monero commented Mar 4, 2019

rebased

moneromooo-monero added some commits Jan 18, 2019

@moneromooo-monero moneromooo-monero force-pushed the moneromooo-monero:init branch from da13086 to 23abe60 Mar 4, 2019

@fluffypony
Copy link
Collaborator

fluffypony left a comment

Reviewed

@fluffypony fluffypony merged commit 23abe60 into monero-project:master Mar 5, 2019

1 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
buildbot/monero-static-osx-10.11 Build done.
Details
buildbot/monero-static-osx-10.12 Build done.
Details
buildbot/monero-static-osx-10.13 Build done.
Details
buildbot/monero-static-ubuntu-i686 Build done.
Details
buildbot/monero-static-win32 Build done.
Details
buildbot/monero-static-win64 Build done.
Details
buildbot/monero-static-ubuntu-amd64 Build done.
Details

fluffypony added a commit that referenced this pull request Mar 5, 2019

Merge pull request #5101
23abe60 check load_t_from_json return values (moneromooo-monero)
e396146 default initialize rpc structures (moneromooo-monero)
ef93b09 various: remove unused variables (moneromooo-monero)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.