Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] disable asm w/ x64 instructions set on i386 #5210

Merged

Conversation

Projects
None yet
4 participants
@naughtyfox
Copy link
Contributor

commented Feb 28, 2019

Related to #5206. This fixes compilation on i386 arch.
If the PR is accepted I'll make a PR to master

@naughtyfox

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

Oh, there's no jit on master yet. No need to make one more PR :)

@fluffypony
Copy link
Collaborator

left a comment

Reviewed

@fluffypony fluffypony merged commit 997830f into monero-project:release-v0.13 Mar 3, 2019

2 of 10 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
buildbot/monero-static-osx-10.11 Build done.
Details
buildbot/monero-static-osx-10.12 Build done.
Details
buildbot/monero-static-osx-10.13 Build done.
Details
buildbot/monero-static-ubuntu-amd64 Build done.
Details
buildbot/monero-static-ubuntu-i686 Build done.
Details
buildbot/monero-static-win32 Build done.
Details
buildbot/monero-static-win64 Build done.
Details
buildbot/monero-linux-armv7 Build done.
Details
buildbot/monero-linux-armv8 Build done.
Details

fluffypony added a commit that referenced this pull request Mar 3, 2019

Merge pull request #5210
997830f disable asm w/ x64 instructions set on i386 (naughtyfox)
@TheCharlatan

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

I don't know much about these instructions, but shouldn't they be compatible across all x86 architectures?

@naughtyfox

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

@TheCharlatan the problem is this code uses x64 extended registers which are not available on i386

@TheCharlatan

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

This still needs to go into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.