Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet API: multisig_tx_set passing bug fixed #5270

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
3 participants
@naughtyfox
Copy link
Contributor

commented Mar 12, 2019

make_multisig_tx_set misuse in wallet api led to inability to properly sign multisig transactions. It took about 1 week to debug it :)

@naughtyfox

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

should I make the same PR against release branch?

@moneromooo-monero

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

If you'll want to have a 0.14.0.3 GUI.

@fluffypony
Copy link
Collaborator

left a comment

Reviewed

@fluffypony fluffypony merged commit 5ade728 into monero-project:master Mar 21, 2019

3 of 10 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
buildbot/monero-static-osx-10.11 Build done.
Details
buildbot/monero-static-osx-10.12 Build done.
Details
buildbot/monero-static-osx-10.13 Build done.
Details
buildbot/monero-static-ubuntu-i686 Build done.
Details
buildbot/monero-static-win32 Build done.
Details
buildbot/monero-static-win64 Build done.
Details
buildbot/monero-linux-armv7 Build done.
Details
buildbot/monero-linux-armv8 Build done.
Details
buildbot/monero-static-ubuntu-amd64 Build done.
Details

fluffypony added a commit that referenced this pull request Mar 21, 2019

Merge pull request #5270
5ade728 Wallet API: multisig_tx_set passing bug fixed (naughtyfox)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.