Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testdb: add override keyword where missing #5413

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
4 participants
@stoffu
Copy link
Contributor

stoffu commented Apr 9, 2019

and delete obsolete BlockchainBDB::get_tx_output_indices along the way

@vtnerd

vtnerd approved these changes Apr 9, 2019

@moneromooo-monero
Copy link
Contributor

moneromooo-monero left a comment

Alright, it's a bit spammy but prevents mistakes.

@fluffypony
Copy link
Collaborator

fluffypony left a comment

Reviewed

Please rebase :)

testdb: add override keyword where missing
and delete obsolete BlockchainBDB::get_tx_output_indices along the way

@stoffu stoffu force-pushed the stoffu:testdb-override branch from da70562 to 5fafb90 Apr 17, 2019

@stoffu

This comment has been minimized.

Copy link
Contributor Author

stoffu commented Apr 17, 2019

Rebased

@fluffypony
Copy link
Collaborator

fluffypony left a comment

Reviewed

@fluffypony fluffypony merged commit 5fafb90 into monero-project:master Apr 17, 2019

0 of 5 checks passed

buildbot/monero-static-ubuntu-amd64 Build done.
Details
buildbot/monero-static-ubuntu-i686 Build done.
Details
buildbot/monero-static-win32 Build done.
Details
buildbot/monero-static-win64 Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

fluffypony added a commit that referenced this pull request Apr 17, 2019

Merge pull request #5413
5fafb90 testdb: add override keyword where missing (stoffu)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.