Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reproducible builds #5632

Merged
merged 4 commits into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@hyc
Copy link
Contributor

commented Jun 12, 2019

Don't use -march=native
Re-enable parallel make

Using -march=native made the binaries depend on the build system's CPU, and those binaries could crash on older machines. This was breaking the Mac binaries. It also meant that the binaries would differ between different build machines. This was causing the differences in the x86-64-linux builds. I've tested with both serial and parallel build, and results are now identical, so parallel make was never the issue.

hyc added some commits Jun 11, 2019

@hyc hyc force-pushed the LMDB:repro2 branch from 93cad6c to f8b2f25 Jun 12, 2019

@hyc hyc referenced this pull request Jun 12, 2019

Merged

Fix reproducible builds #5633

@hyc hyc force-pushed the LMDB:repro2 branch 2 times, most recently from 30ad3e4 to 9503712 Jun 12, 2019

@hyc hyc force-pushed the LMDB:repro2 branch from 9503712 to 1dc4ebf Jun 12, 2019

@luigi1111 luigi1111 merged commit 1dc4ebf into monero-project:master Jun 12, 2019

3 of 7 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
buildbot/monero-linux-armv8 Build done.
Details
buildbot/monero-static-osx-10.11 Build started.
Details
buildbot/monero-static-osx-10.13 Build started.
Details
buildbot/monero-linux-armv7 Build done.
Details
buildbot/monero-static-ubuntu-amd64 Build done.
Details
buildbot/monero-static-ubuntu-i686 Build done.
Details

luigi1111 added a commit that referenced this pull request Jun 12, 2019

Merge pull request #5632
3a0fbea Don't use -march=native (hyc)
f8b2f25 Allow parallel make (hyc)
01ced20 Delete redundant cppzmq dependency (hyc)
1dc4ebf Use 9 digit build IDs (hyc)

@hyc hyc deleted the LMDB:repro2 branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.