Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reproducible builds #5633

Merged
merged 4 commits into from Jun 12, 2019

Conversation

Projects
None yet
4 participants
@hyc
Copy link
Contributor

commented Jun 12, 2019

Don't use -march=native
Re-enable parallel make

Using -march=native made the binaries depend on the build system's CPU, and those binaries could crash on older machines. This was breaking the Mac binaries. It also meant that the binaries would differ between different build machines. This was causing the differences in the x86-64-linux builds. I've tested with both serial and parallel build, and results are now identical, so parallel make was never the issue.

hyc added some commits Jun 11, 2019

@hyc

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

This is same as #5632 but for release branch.

@hyc hyc force-pushed the LMDB:repro2-v0.14 branch from dc47f00 to 931d99e Jun 12, 2019

@hyc hyc force-pushed the LMDB:repro2-v0.14 branch from 931d99e to 86591eb Jun 12, 2019

@luigi1111 luigi1111 merged commit 86591eb into monero-project:release-v0.14 Jun 12, 2019

5 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
buildbot/monero-linux-armv8 Build done.
Details
buildbot/monero-static-osx-10.12 Build started.
Details
buildbot/monero-linux-armv7 Build done.
Details
buildbot/monero-static-osx-10.11 Build done.
Details
buildbot/monero-static-osx-10.13 Build done.
Details
buildbot/monero-static-ubuntu-amd64 Build done.
Details
buildbot/monero-static-ubuntu-i686 Build done.
Details

luigi1111 added a commit that referenced this pull request Jun 12, 2019

Merge pull request #5633
cfa88ac Don't use -march=native (hyc)
e85bf46 Allow parallel make (hyc)
0ef8391 Delete redundant cppzmq dependency (hyc)
86591eb Use 9 digit build IDs (hyc)

@hyc hyc deleted the LMDB:repro2-v0.14 branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.