Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling, grammar, and punctuation corrections on README.md #5686

Open

Conversation

@cryptographicfool
Copy link

commented Jun 22, 2019

I noticed a few minor spelling, grammar and punctuation mistakes on the README.md file and decided to fix them.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@cryptographicfool

This comment has been minimized.

Copy link
Author

commented Jun 22, 2019

Thank you for the review @moneromooo-monero . I have made the corrections.
Cheers!

@cryptographicfool

This comment has been minimized.

Copy link
Author

commented Jun 23, 2019

Why do these build tests fail? I just updated README.md

@selsta

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2019

@cryptographicfool They aren’t failing. monero-static-win32 isn’t setup correctly at the moment because we don’t do win32 builds anymore.

@cryptographicfool

This comment has been minimized.

Copy link
Author

commented Jun 23, 2019

@cryptographicfool They aren’t failing. monero-static-win32 isn’t setup correctly at the moment because we don’t do win32 builds anymore.

@selsta After going through the details and looking at other PRs, I realized the same. Thanks for clarifying. Cheers!

@dEBRUYNE-1

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

@cryptographicfool - Could you squash the two commits into one?

Made spelling, grammar, and punctuation changes. Squashed commtits in…
…to one as requested.

Made some corrections as suggested.
@cryptographicfool

This comment has been minimized.

Copy link
Author

commented Jul 10, 2019

@cryptographicfool - Could you squash the two commits into one?

@dEBRUYNE-1 I have squashed the two commits, but as the previous commits are already in the pull request and the changes have been verified by @moneromooo-monero ; I am having to use force push. I am not sure if that is the right thing to do, but I could be wrong.

If I should force push, I will do it right away. Otherwise, I am keeping these as it is for the moment.

Thank you!

@selsta

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

You can force-push.

@cryptographicfool cryptographicfool force-pushed the cryptographicfool:readme_spellingandgrammar branch from 229d6dd to a96e3b9 Jul 10, 2019

@cryptographicfool

This comment has been minimized.

Copy link
Author

commented Jul 10, 2019

You can force-push.

Done. :)

@luigi1111

This comment has been minimized.

Copy link
Collaborator

commented Aug 15, 2019

@cryptographicfool looks like it'll need one more rebase.

@dEBRUYNE-1

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.