Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed i2p/tor tx flooding bug (white noise disabled) #5921

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@vtnerd
Copy link
Contributor

commented Sep 21, 2019

Noticed this bug while working on mempool/dandelion++ stuff. If white noise is disabled for i2p/tor, it shouldn't use the flooding behavior used on public networks - the txes should only be sent over outgoing i2p/tor connections. Otherwise, a link to the i2p/tor exit node address can be made. Includes new tests to verify this behavior.

@vtnerd

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2019

Oh bother, theres a blantant bug in this patch that coudn't easily be caught in unit tests. The second constructor call needs to be false not true, @moneromooo-monero I will link old hash and new hash in a second.

@vtnerd vtnerd force-pushed the vtnerd:fix/tor_flood branch from aec1909 to 2a7d915 Sep 21, 2019
@vtnerd

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2019

A link to the diff of the last change.

@vtnerd vtnerd referenced this pull request Oct 7, 2019
luigi1111 added a commit that referenced this pull request Oct 8, 2019
2a7d915 Fixed i2p/tor tx flooding bug (white noise disabled) (vtnerd)
@luigi1111 luigi1111 merged commit 2a7d915 into monero-project:master Oct 8, 2019
3 of 7 checks passed
3 of 7 checks passed
buildbot/monero-static-osx-10.11 Build done.
Details
buildbot/monero-static-osx-10.12 Build done.
Details
buildbot/monero-static-osx-10.13 Build done.
Details
buildbot/monero-static-win32 Build started.
Details
buildbot/monero-static-ubuntu-i686 Build done.
Details
buildbot/monero-static-win64 Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.