Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: allow message sign/verify for subaddresses #6069

Open
wants to merge 1 commit into
base: master
from

Conversation

@moneromooo-monero
Copy link
Contributor

moneromooo-monero commented Oct 31, 2019

No description provided.

@stoffu
stoffu approved these changes Nov 1, 2019
@moneromooo-monero moneromooo-monero force-pushed the moneromooo-monero:svsub branch from b9add93 to 4f3ab08 Nov 5, 2019
@@ -214,7 +214,7 @@ namespace
const char* USAGE_GET_TX_NOTE("get_tx_note <txid>");
const char* USAGE_GET_DESCRIPTION("get_description");
const char* USAGE_SET_DESCRIPTION("set_description [free text note]");
const char* USAGE_SIGN("sign <filename>");
const char* USAGE_SIGN("sign [<account_index>,<address_index>] <filename>");

This comment has been minimized.

Copy link
@vtnerd

vtnerd Dec 1, 2019

Contributor

Why move the filename position? Putting the indexes after would mean existing usage remains unchanged (defaults to primary account).

This comment has been minimized.

Copy link
@moneromooo-monero

moneromooo-monero Dec 2, 2019

Author Contributor

Because it's what other commands do. AFAIK existing usage remains unchanged. Did you try it and it changed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.