Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: remove old debug commands #6275

Open
wants to merge 1 commit into
base: master
from

Conversation

@ahook
Copy link

ahook commented Dec 31, 2019

As described in this issue: #6271, the code has strayed enough since ALLOW_DEBUG_COMMANDS was defaulted on, that turning it off no longer builds.

There are a couple ways to handle the issue, the least invasive being just fixing the build. But @moneromooo-monero commented that removing them altogether might be the better option, since they are effectively unusable.

This patch removes those debug commands and the associated code. If the consensus after further thought decides that it's too heavy-handed, I have another patch ready which simply gets things into a sane state that can build if someone decides to comment out the macro.

Aaron Hook
@vtnerd
vtnerd approved these changes Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.