Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logging for dropped local txes with no i2p/tor connections #6375

Merged
merged 1 commit into from Apr 4, 2020

Conversation

@vtnerd
Copy link
Contributor

vtnerd commented Mar 7, 2020

No description provided.

@vtnerd

This comment has been minimized.

Copy link
Contributor Author

vtnerd commented Mar 7, 2020

These print with the default log level.

@@ -44,6 +44,9 @@
#include "net/dandelionpp.h"
#include "p2p/net_node.h"

#undef MONERO_DEFAULT_LOG_CATEGORY
#define MONERO_DEFAULT_LOG_CATEGORY "net.p2p.tx"

This comment has been minimized.

Copy link
@moneromooo-monero

moneromooo-monero Mar 8, 2020

Collaborator

Not really a good name since most of the p2p tx logs are not here.

This comment has been minimized.

Copy link
@vtnerd

vtnerd Mar 8, 2020

Author Contributor

This name still seemed relevant - its specifically p2p transaction traffic ... ?

src/cryptonote_protocol/levin_notify.cpp Show resolved Hide resolved
@vtnerd vtnerd force-pushed the vtnerd:fix/tor_error_logging branch from 9ceb93a to ebf3c10 Mar 8, 2020
@vtnerd

This comment has been minimized.

Copy link
Contributor Author

vtnerd commented Mar 8, 2020

I added a log when a "diffusion" has no connections for sending. This covers both public and i2p/tor when noise is disabled. There is no log statement for "stems", because Dandelion++ is not yet merged.

@luigi1111 luigi1111 merged commit 975825a into monero-project:master Apr 4, 2020
5 of 6 checks passed
5 of 6 checks passed
build-macos
Details
build-windows build-windows
Details
build-ubuntu
Details
libwallet-ubuntu
Details
test-ubuntu
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.