Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logging for dropped local txes with no i2p/tor connections (0.15 branch) #6376

Merged

Conversation

@vtnerd
Copy link
Contributor

vtnerd commented Mar 7, 2020

No description provided.

@vtnerd

This comment has been minimized.

Copy link
Contributor Author

vtnerd commented Mar 7, 2020

Identical to PR 6375 but for 0.15 branch.

Copy link
Contributor

rbrunner7 left a comment

Don't know much about anonymity networks, but this is only adding logging, and that does look ok.

@vtnerd vtnerd force-pushed the vtnerd:fix/tor_error_logging-0.15 branch from 6f90210 to 6177e49 Mar 8, 2020
@vtnerd

This comment has been minimized.

Copy link
Contributor Author

vtnerd commented Mar 8, 2020

I force pushed a change just after your comment. This adds a log statement for public networks and anonymity networks when noise is disabled. This differs from the patch to master, because this branch does not have "diffusion" - it is using the simpler "flood" algorithm for notification.

@rbrunner7

This comment has been minimized.

Copy link
Contributor

rbrunner7 commented Mar 8, 2020

Well, after checking again and also comparing with the code changes for the master branch I have to admit maybe I was a little fast and not the right person to review this after all ...

@luigi1111 luigi1111 merged commit 17ec003 into monero-project:release-v0.15 Mar 9, 2020
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.