Skip to content
Permalink
Browse files

Cached allowed categories in easylogging++

  • Loading branch information...
miltonf committed Mar 12, 2019
1 parent 479eaeb commit 268b789c199cb3fc72f010bd7efc972d1455f2be
Showing with 12 additions and 1 deletion.
  1. +10 −1 external/easylogging++/easylogging++.cc
  2. +2 −0 external/easylogging++/easylogging++.h
@@ -1967,10 +1967,12 @@ void VRegistry::setCategories(const char* categories, bool clear) {
base::threading::ScopedLock scopedLock(lock());
auto insert = [&](std::stringstream& ss, Level level) {
m_categories.push_back(std::make_pair(ss.str(), level));
m_cached_allowed_categories.clear();
};

if (clear) {
m_categories.clear();
m_cached_allowed_categories.clear();
m_categoriesString.clear();
}
if (!m_categoriesString.empty())
@@ -2033,15 +2035,22 @@ static int priority(Level level) {

bool VRegistry::allowed(Level level, const char* category) {
base::threading::ScopedLock scopedLock(lock());
const std::string scategory = category;
const std::map<std::string, int>::const_iterator it = m_cached_allowed_categories.find(scategory);
if (it != m_cached_allowed_categories.end())
return priority(level) <= it->second;
if (m_categories.empty() || category == nullptr) {
return false;
} else {
std::deque<std::pair<std::string, Level>>::const_reverse_iterator it = m_categories.rbegin();
for (; it != m_categories.rend(); ++it) {
if (base::utils::Str::wildCardMatch(category, it->first.c_str())) {
return priority(level) <= priority(it->second);
const int p = priority(it->second);
m_cached_allowed_categories.insert(std::make_pair(std::move(scategory), p));
return priority(level) <= p;
}
}
m_cached_allowed_categories.insert(std::make_pair(std::move(scategory), -1));
return false;
}
}
@@ -2485,6 +2485,7 @@ class VRegistry : base::NoCopy, public base::threading::ThreadSafe {
inline void clearCategories(void) {
base::threading::ScopedLock scopedLock(lock());
m_categories.clear();
m_cached_allowed_categories.clear();
}

inline void clearModules(void) {
@@ -2526,6 +2527,7 @@ class VRegistry : base::NoCopy, public base::threading::ThreadSafe {
base::type::EnumType* m_pFlags;
std::map<std::string, base::type::VerboseLevel> m_modules;
std::deque<std::pair<std::string, Level>> m_categories;
std::map<std::string, int> m_cached_allowed_categories;
std::string m_categoriesString;
std::string m_filenameCommonPrefix;
};

0 comments on commit 268b789

Please sign in to comment.
You can’t perform that action at this time.