Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#220 fix for *.isInstance methods #221

Merged
merged 2 commits into from Jan 14, 2020
Merged

#220 fix for *.isInstance methods #221

merged 2 commits into from Jan 14, 2020

Conversation

@wookieb
Copy link

wookieb commented Jan 12, 2020

No description provided.

Łukasz Kużyński
Copy link
Collaborator

tomecko left a comment

LGTM, please see minor comments

test/either-spec.js Outdated Show resolved Hide resolved
test/io-spec.js Outdated Show resolved Hide resolved
test/either-spec.js Outdated Show resolved Hide resolved
@ulfryk ulfryk added this to the 0.9.1 milestone Jan 13, 2020
src/monet.js Show resolved Hide resolved
src/monet.js Show resolved Hide resolved
@ulfryk

This comment has been minimized.

Copy link
Member

ulfryk commented Jan 13, 2020

To be sure that the bug was fixed (and does not reappear in future) we need exact testing on all boolean values returned from checking methods. So as soon as all truthy/falsy checks are switched to true/false we can merge this one and release patch :)

@wookieb

This comment has been minimized.

Copy link
Author

wookieb commented Jan 13, 2020

@ulfryk No problem. I'll do it later today once I finish work :)

Łukasz Kużyński
@ulfryk
ulfryk approved these changes Jan 14, 2020
@ulfryk ulfryk merged commit 0abb87d into monet:develop Jan 14, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.