New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow displaying transactions in an Account #980

Closed
grumpy235 opened this Issue Jan 3, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@grumpy235

grumpy235 commented Jan 3, 2017

make sure these boxed are checked before submitting your issue - thank you!

  • Check OS
    • Windows
    • Mac OSX
    • Linux
  • Check MMEX version
  • 1.3.x

Noticable slow down when displaying transactions (6000+) in a Checking Account compared to 1.2.7
Compiling latest source on Win10 and VS2015 and running debug shows the following Hotpath
TransactionListCtrl::OnGetItemAttr 60%
wxDateTime::ResetTime 30%
wxDateTime::FormatISODate 30%

The following line in mmcheckingpanel.cpp appears to be the problem
1341 bool in_the_future = tran.TRANSDATE > wxDateTime::Today().FormatISODate();

Looks like a similar sort of problem to the one I reported in [http://forum.moneymanagerex.org/viewtopic.php?f=23&p=14569&sid=6fbc165bfa645ab2aa5c53aed48e0741#p14569] which was recently fixed.

Changing line 1341 to simply
bool in_the_future = false;
and the problem goes away.

I guess more problems with evaluating wxDateTime::Today().FormatISODate() under latest Win10 - I assume it is evaluated everytime the line is executed ?

Whilst messing with this I set a breakpoint on 1341 and then stepped through the program, was somewhat surprised to see that the line was hit around 10 times for no apparent change in the data certainly the tran record was the same each time until we eventually moved on to another account record.

@vomikan vomikan self-assigned this Jan 3, 2017

@vomikan vomikan added the bug label Jan 3, 2017

@vomikan vomikan added this to the v1.3 milestone Jan 3, 2017

vomikan added a commit that referenced this issue Jan 3, 2017

Merge pull request #981 from vomikan/#980
fix(#980): speedup by reducing the use of wxdatetime::today
@grumpy235

This comment has been minimized.

grumpy235 commented Jan 4, 2017

Nikolay,
Many thanks - instant display now.
This problem got me looking at User Colors in "View Options", is there any documentation on to use them? I could not find much in the Help file.

@vomikan

This comment has been minimized.

Contributor

vomikan commented Jan 4, 2017

In an account panel if Ctrl+1....Ctrl+7 have pressed the selected transaction will marked by specified color. Ctrl+0 is for reset.

@guanlisheng guanlisheng modified the milestones: v1.3, v1.3.x Jan 4, 2017

stef145g added a commit to stef145g/moneymanagerex that referenced this issue Jan 4, 2017

@vomikan vomikan closed this Jan 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment