From f1b48128a4ea972185fec2cf118fa0e84fd05d43 Mon Sep 17 00:00:00 2001 From: Pedro Cuba Date: Wed, 23 Oct 2024 14:37:29 +0900 Subject: [PATCH 1/2] chore(ci): Fix linting job in CircleCI The command being run by Circle CI would not return an error code if the linting failed on the JS step, because it only looked at the exit code of linting the TS files. --- .circleci/config.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 22bd84e..33b5b98 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -37,7 +37,10 @@ jobs: - *attach_workspace - run: name: Linting JavaScript - command: yarn lint + command: yarn lint:js + - run: + name: Linting TypeScript + command: yarn lint:ts unit_test: <<: *docker_defaults From cc244c6ef55e08465ac81132be822df5e7e0e417 Mon Sep 17 00:00:00 2001 From: Pedro Cuba Date: Wed, 23 Oct 2024 14:38:47 +0900 Subject: [PATCH 2/2] chore(lint): Ignore auto-generated doc files when linting with eslint --- .eslintrc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.eslintrc.js b/.eslintrc.js index 3d22f68..9443a14 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -14,5 +14,5 @@ module.exports = { ecmaVersion: 11 }, plugins: ['prettier'], - ignorePatterns: ['dist'] + ignorePatterns: ['dist', 'docs'] };