[LINK-4184] Store code_verifier in localStorage
#167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mt-dfrey is this also a version bump of the package since it changes behaviour? |
Contributor
Yes, we want to release this a new SDK version. This fixes a bug, so I suggest we make it a patch version (see semantic versioning). You can either make the version bump in this PR, since the diff is so small. Or create another PR with the version bump & Changelog entry. Let's pair on actually releasing the new SDK version. |
mt-dfrey
approved these changes
Mar 3, 2025
Contributor
Author
|
Nice, that makes sense to me. I'll make another PR for the bump/changelog changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As decided in the ADR
sessionStoragewithlocalStoragecvinlocalStorageafterexchangeTokensucceeds