fixup: remove peer dep check workaround

Author: addaleax

packages/compass-electron-menu/package.json

@@ -55,6 +55,7 @@
   "dependencies": {
     "bson": "^6.10.4",
     "debug": "^4.3.4",
+    "electron": "^37.6.1",
     "react": "^17.0.2"
   },
   "devDependencies": {
@@ -70,7 +71,6 @@
     "@types/react-dom": "^17.0.10",
     "@types/sinon-chai": "^3.2.5",
     "chai": "^4.3.6",
-    "electron": "^37.6.1",
     "depcheck": "^1.4.1",
     "gen-esm-wrapper": "^1.1.0",
     "mocha": "^10.2.0",

packages/compass-electron-menu/src/types.ts

@@ -1,6 +1,7 @@
-// Type-only import in a separate entry point, so this is fine
-// compass-peer-deps-ignore
-// eslint-disable-next-line @typescript-eslint/no-restricted-imports
+// NB: We add `electron` as a production dependency because
+// of this type import. That's fine because we expect this
+// package to only be used in Compass, where we know elecron
+// is a dependency anyway.
 import type { MenuItemConstructorOptions } from 'electron';
 
 export type { MenuItemConstructorOptions };

scripts/check-peer-deps.js

@@ -77,27 +77,19 @@ async function collectAllAbsoluteImports(entryPoints = []) {
         ],
       ],
     });
-    const shouldSkip = (path) =>
-      path.node.leadingComments?.some((comment) =>
-        comment.value?.includes('compass-peer-deps-ignore')
-      );
     traverse(program, {
       ImportDeclaration(path) {
-        if (shouldSkip(path)) return;
         queueImport(path.node.source.value);
       },
       ExportNamedDeclaration(path) {
-        if (shouldSkip(path)) return;
         if (path.node.source) {
           queueImport(path.node.source.value);
         }
       },
       ExportAllDeclaration(path) {
-        if (shouldSkip(path)) return;
         queueImport(path.node.source.value);
       },
       CallExpression(path) {
-        if (shouldSkip(path)) return;
         if (
           path.node.callee.type === 'Identifier' &&
           (path.node.callee.name === 'require' ||