From 2e8ec24abf87742adb27c611d5f9ffa52b05c25e Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Thu, 17 Aug 2017 14:33:22 +1000 Subject: [PATCH 1/3] COMPASS 1727: Remove onQueryChanged listeners from onActivated Stops onQueryChanged being called twice in Compass. --- src/internal-packages/explain/lib/stores/index.js | 1 - src/internal-packages/schema/lib/store/index.js | 1 - 2 files changed, 2 deletions(-) diff --git a/src/internal-packages/explain/lib/stores/index.js b/src/internal-packages/explain/lib/stores/index.js index ba0ff2ec94e..ce1301c0f75 100644 --- a/src/internal-packages/explain/lib/stores/index.js +++ b/src/internal-packages/explain/lib/stores/index.js @@ -34,7 +34,6 @@ const CompassExplainStore = Reflux.createStore({ }, onActivated(appRegistry) { - appRegistry.getStore('Query.ChangedStore').listen(this.onQueryChanged.bind(this)); appRegistry.getStore('Indexes.IndexStore').listen(this.indexesChanged.bind(this)); appRegistry.getStore('App.NamespaceStore').listen(this.onNamespaceChanged.bind(this)); this.CollectionStore = appRegistry.getStore('App.CollectionStore'); diff --git a/src/internal-packages/schema/lib/store/index.js b/src/internal-packages/schema/lib/store/index.js index 36c790be814..95da3de96e2 100644 --- a/src/internal-packages/schema/lib/store/index.js +++ b/src/internal-packages/schema/lib/store/index.js @@ -51,7 +51,6 @@ const SchemaStore = Reflux.createStore({ }, onActivated(appRegistry) { - appRegistry.getStore('Query.ChangedStore').listen(this.onQueryChanged.bind(this)); appRegistry.getStore('App.NamespaceStore').listen(this.onNamespaceChanged.bind(this)); }, From 68c69e6044b4e3647428b5aac9b48591fb9c4cb2 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Thu, 17 Aug 2017 15:20:26 +1000 Subject: [PATCH 2/3] npm i @mongodb-js/compass-crud@0.2.1 --save --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index c16dbbd7247..1e936c90f29 100644 --- a/package.json +++ b/package.json @@ -131,11 +131,11 @@ }, "dependencies": { "@mongodb-js/compass-charts": "^0.2.3", - "@mongodb-js/compass-crud": "0.2.0", + "@mongodb-js/compass-crud": "^0.2.1", "@mongodb-js/compass-deployment-awareness": "3.2.0", "@mongodb-js/compass-document-validation": "4.1.0", - "@mongodb-js/compass-serverstats": "9.1.1", "@mongodb-js/compass-query-history": "0.3.0", + "@mongodb-js/compass-serverstats": "9.1.1", "ampersand-collection": "^1.5.0", "ampersand-collection-filterable": "^0.2.1", "ampersand-dom-bindings": "^3.7.0", From d59fa0b4852d3c2e76b99f6b91a2de80141ac168 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Thu, 17 Aug 2017 15:20:44 +1000 Subject: [PATCH 3/3] Go back to pinned versions --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 1e936c90f29..f635fd463c0 100644 --- a/package.json +++ b/package.json @@ -131,7 +131,7 @@ }, "dependencies": { "@mongodb-js/compass-charts": "^0.2.3", - "@mongodb-js/compass-crud": "^0.2.1", + "@mongodb-js/compass-crud": "0.2.1", "@mongodb-js/compass-deployment-awareness": "3.2.0", "@mongodb-js/compass-document-validation": "4.1.0", "@mongodb-js/compass-query-history": "0.3.0",