From da484bbf19fcaf9a3c0ad182384bf0f067bd0802 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Thu, 28 Sep 2017 15:36:10 +1000 Subject: [PATCH 01/15] :fire: Remove #databases dropDatabase('music') call It was not created by this test, so if it's needed it would be for earlier test runs? I don't see value in keeping it. Plus - it might be how the chain of test timeouts gets broken? Let's find out with another test. --- test/functional/databases.test.js | 9 --------- 1 file changed, 9 deletions(-) diff --git a/test/functional/databases.test.js b/test/functional/databases.test.js index 2c9acc110aa..c3dfea73ff2 100644 --- a/test/functional/databases.test.js +++ b/test/functional/databases.test.js @@ -39,15 +39,6 @@ describe('#databases', function() { }); }); - after(function(done) { - dataService.connect(function() { - dataService.dropDatabase('music', function() { - dataService.disconnect(); - done(); - }); - }); - }); - context('when the escape key is pressed', function() { it('closes the create databases modal', function() { return client From 1a41505e47d98e15c04684e2f55ddb4695b9180d Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Fri, 29 Sep 2017 11:45:40 +1000 Subject: [PATCH 02/15] :bug: Handle the case where app is undefined This should be the second failure in at least one of the "main failure chain" pairs, i.e. https://travis-ci.com/10gen/compass/jobs/92384423 (but not) https://travis-ci.com/10gen/compass/jobs/92384429 --- test/functional/support/spectron-support.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/functional/support/spectron-support.js b/test/functional/support/spectron-support.js index 0c7fdaf0014..37c2f7ddc62 100644 --- a/test/functional/support/spectron-support.js +++ b/test/functional/support/spectron-support.js @@ -65,11 +65,13 @@ function launchCompass() { * Call quitCompass in afterEach for all UI tests: * @param {Object} app - The running application - * @param {Function} done - The callback to execute when finished. * - * @returns {Promise} Promise that resolves when app stops. + * @returns {Promise} Promise that resolves when app stops or is undefined. */ function quitCompass(app) { + if (app === undefined) { + return Promise.resolve(); + } return app.quit(); } From c72fa92a4cf073cc41f0ac899c8b51daec665534 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Fri, 29 Sep 2017 12:15:30 +1000 Subject: [PATCH 03/15] :bug: Handle app null as well as undefined https://travis-ci.com/10gen/compass/jobs/92556220 --- test/functional/support/spectron-support.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/functional/support/spectron-support.js b/test/functional/support/spectron-support.js index 37c2f7ddc62..eac85eef431 100644 --- a/test/functional/support/spectron-support.js +++ b/test/functional/support/spectron-support.js @@ -69,7 +69,7 @@ function launchCompass() { * @returns {Promise} Promise that resolves when app stops or is undefined. */ function quitCompass(app) { - if (app === undefined) { + if (app === undefined || app === null) { return Promise.resolve(); } return app.quit(); From 5d9b660aeddea3da232c1e434e28f7819fedd626 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Fri, 29 Sep 2017 18:16:02 +1000 Subject: [PATCH 04/15] :construction: Try container-based infrastructure Just seeing if it's a cheap win today. https://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/ --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index abeb101e7c5..14020b98f8f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,4 +1,4 @@ -sudo: required +sudo: false dist: trusty language: node_js node_js: From aaabed475df88f87f0e578a9cb1709435692a95b Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Tue, 3 Oct 2017 12:47:30 +1100 Subject: [PATCH 05/15] :art: Remove clickDatabaseInSidebar/waitForSidebar calls They are redundant as they are already done by goToCollection, which is at least a code smell worthwhile removing. --- test/functional/schema.test.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/functional/schema.test.js b/test/functional/schema.test.js index 8573631c5c8..cc02eb3c358 100644 --- a/test/functional/schema.test.js +++ b/test/functional/schema.test.js @@ -62,8 +62,6 @@ describe('#schema', function() { it('shows a schema on refresh', function() { return client - .clickDatabaseInSidebar('music') - .waitForSidebar('collection') .goToCollection('music', 'artists') .clickApplyFilterButtonFromSchemaTab() .waitForStatusBar() From 6806f51ac5e72217a093443a404d5dcb04588044 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Mon, 13 Mar 2017 12:37:11 +1100 Subject: [PATCH 06/15] noop --- test/functional/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/test/functional/README.md b/test/functional/README.md index 2f743e698ce..d9e5e4c495e 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -75,6 +75,7 @@ describe('Compass Functional Test Suite #spectron', function() { }); ``` + ## Tips ### Running subsets of the functional suite From debcd5e530dcc674cefe18e2d4e5e173fec58aca Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Thu, 28 Sep 2017 12:50:06 +1000 Subject: [PATCH 07/15] Revert "noop" --- test/functional/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/test/functional/README.md b/test/functional/README.md index d9e5e4c495e..2f743e698ce 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -75,7 +75,6 @@ describe('Compass Functional Test Suite #spectron', function() { }); ``` - ## Tips ### Running subsets of the functional suite From 89b9167caa2c972b093aa4436ee377128b3ff523 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Mon, 13 Mar 2017 12:37:11 +1100 Subject: [PATCH 08/15] noop --- test/functional/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/test/functional/README.md b/test/functional/README.md index 2f743e698ce..d9e5e4c495e 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -75,6 +75,7 @@ describe('Compass Functional Test Suite #spectron', function() { }); ``` + ## Tips ### Running subsets of the functional suite From 38102fce18cb0e34412c8c9c0c5361e1a3549b87 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Thu, 28 Sep 2017 12:50:06 +1000 Subject: [PATCH 09/15] Revert "noop" --- test/functional/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/test/functional/README.md b/test/functional/README.md index d9e5e4c495e..2f743e698ce 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -75,7 +75,6 @@ describe('Compass Functional Test Suite #spectron', function() { }); ``` - ## Tips ### Running subsets of the functional suite From 06cc6075d16a8126d7a115489f5501476ea18300 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Mon, 13 Mar 2017 12:37:11 +1100 Subject: [PATCH 10/15] noop --- test/functional/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/test/functional/README.md b/test/functional/README.md index 2f743e698ce..d9e5e4c495e 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -75,6 +75,7 @@ describe('Compass Functional Test Suite #spectron', function() { }); ``` + ## Tips ### Running subsets of the functional suite From d1b6288cc4632fa1bf1e7c14af74024b07d04d92 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Thu, 28 Sep 2017 12:50:06 +1000 Subject: [PATCH 11/15] Revert "noop" --- test/functional/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/test/functional/README.md b/test/functional/README.md index d9e5e4c495e..2f743e698ce 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -75,7 +75,6 @@ describe('Compass Functional Test Suite #spectron', function() { }); ``` - ## Tips ### Running subsets of the functional suite From 1bdc9601fe656a085505c516ea27e23d56202d56 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Mon, 13 Mar 2017 12:37:11 +1100 Subject: [PATCH 12/15] noop --- test/functional/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/test/functional/README.md b/test/functional/README.md index 2f743e698ce..d9e5e4c495e 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -75,6 +75,7 @@ describe('Compass Functional Test Suite #spectron', function() { }); ``` + ## Tips ### Running subsets of the functional suite From b41f9b4c0ff12bf9e723dbe00c68d6fa27aa8e3d Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Thu, 28 Sep 2017 12:50:06 +1000 Subject: [PATCH 13/15] Revert "noop" --- test/functional/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/test/functional/README.md b/test/functional/README.md index d9e5e4c495e..2f743e698ce 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -75,7 +75,6 @@ describe('Compass Functional Test Suite #spectron', function() { }); ``` - ## Tips ### Running subsets of the functional suite From ccc5ae927ed15d2d64db7bcf8478ee29fa9e0f5f Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Mon, 13 Mar 2017 12:37:11 +1100 Subject: [PATCH 14/15] noop --- test/functional/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/test/functional/README.md b/test/functional/README.md index 2f743e698ce..d9e5e4c495e 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -75,6 +75,7 @@ describe('Compass Functional Test Suite #spectron', function() { }); ``` + ## Tips ### Running subsets of the functional suite From 707ead83c708bd305c3f6b89875d49e88006d0d0 Mon Sep 17 00:00:00 2001 From: Peter Schmidt Date: Thu, 28 Sep 2017 12:50:06 +1000 Subject: [PATCH 15/15] Revert "noop" --- test/functional/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/test/functional/README.md b/test/functional/README.md index d9e5e4c495e..2f743e698ce 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -75,7 +75,6 @@ describe('Compass Functional Test Suite #spectron', function() { }); ``` - ## Tips ### Running subsets of the functional suite