From 886ba4997f27439ce308bee919acd42f7214b302 Mon Sep 17 00:00:00 2001 From: Thomas Rueckstiess Date: Wed, 4 Nov 2015 22:43:26 +1100 Subject: [PATCH] :bug: transform must be defined before being called hoisting it to the top of the function didn't work here. --- src/minicharts/d3fns/geo.js | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/src/minicharts/d3fns/geo.js b/src/minicharts/d3fns/geo.js index 492353ca25e..47fe7b23054 100644 --- a/src/minicharts/d3fns/geo.js +++ b/src/minicharts/d3fns/geo.js @@ -251,11 +251,22 @@ var minicharts_d3fns_geo = function() { // Draw each marker as a separate SVG element. overlay.draw = function() { var layer = d3.select('div.layer'); - var transform; projection = this.getProjection(); var padding = 9; + var transform = function(d) { + var p = new google.maps.LatLng(d[1], d[0]); + p = projection.fromLatLngToDivPixel(p); + d.x = p.x; + d.y = p.y; + var self = d3.select(this); + self + .style('left', p.x - padding + 'px') + .style('top', p.y - padding + 'px'); + return self; + }; + var marker = layer.selectAll('svg.marker') .data(data) .each(transform) // update existing markers @@ -268,18 +279,6 @@ var minicharts_d3fns_geo = function() { .attr('r', 4.5) .attr('cx', padding) .attr('cy', padding); - - transform = function(d) { - var p = new google.maps.LatLng(d[1], d[0]); - p = projection.fromLatLngToDivPixel(p); - d.x = p.x; - d.y = p.y; - var self = d3.select(this); - self - .style('left', p.x - padding + 'px') - .style('top', p.y - padding + 'px'); - return self; - }; }; // end overlay.draw overlay.setMap(googleMap);