From cac8434b321a7cacf557a5276720b344a77af619 Mon Sep 17 00:00:00 2001 From: Thomas Rueckstiess Date: Thu, 5 Nov 2015 13:45:42 +1100 Subject: [PATCH 1/2] INT-741 :tada: persisting last known version to localstorage This is for future updates that want to know what version the user has used before. E.g. feature tour only shows new features, internal data structure schemas might change and need migration, etc. --- src/app.js | 1 - src/home/index.js | 5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app.js b/src/app.js index a4856c3afe0..9d8c7ba99cc 100644 --- a/src/app.js +++ b/src/app.js @@ -259,7 +259,6 @@ app.extend({ * * @param {String} id - A key in `FEATURES`. * @param {Boolean} bool - whether to enable (true) or disable (false) - * @return {Boolean} */ setFeature: function(id, bool) { FEATURES[id] = bool; diff --git a/src/home/index.js b/src/home/index.js index bdc55610fda..f532417d682 100644 --- a/src/home/index.js +++ b/src/home/index.js @@ -51,9 +51,10 @@ var HomeView = View.extend({ }, render: function() { this.renderWithTemplate(this); - if (_.isUndefined(localStorage.tourHasRun)) { + if (_.isUndefined(localStorage.lastKnownVersion) + || localStorage.lastKnownVersion !== app.meta['App Version']) { this.renderSubview(new TourView(), this.queryByHook('tour-container')); - localStorage.tourHasRun = 'true'; + localStorage.lastKnownVersion = app.meta['App Version']; } }, onInstanceFetched: function() { From 6eb68bfc891963944c2799070727c6856954c986 Mon Sep 17 00:00:00 2001 From: Waley Date: Thu, 5 Nov 2015 11:04:44 -0500 Subject: [PATCH 2/2] INT-741 :tada: persisting last known version to localstorage patch --- src/home/index.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/home/index.js b/src/home/index.js index f532417d682..40dd18c9cc7 100644 --- a/src/home/index.js +++ b/src/home/index.js @@ -1,4 +1,3 @@ -var _ = require('lodash'); var View = require('ampersand-view'); var format = require('util').format; var SidebarView = require('../sidebar'); @@ -51,8 +50,7 @@ var HomeView = View.extend({ }, render: function() { this.renderWithTemplate(this); - if (_.isUndefined(localStorage.lastKnownVersion) - || localStorage.lastKnownVersion !== app.meta['App Version']) { + if (localStorage.lastKnownVersion !== app.meta['App Version']) { this.renderSubview(new TourView(), this.queryByHook('tour-container')); localStorage.lastKnownVersion = app.meta['App Version']; }