From 57039e5c9fad07d4f08387e15b7473b84d41f216 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 16 Jun 2021 14:04:45 +0200 Subject: [PATCH 1/2] fix(connection-model): make mongodb a proper dependency MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This package depends on the mongodb driver not just as a dev requirement, but also for its actual code. I’ve spent some time trying to make it compatible so that it would work with the 4.0 driver as well, but that seems like a larger task after all and it probably makes more sense to just do proper npm dependency declaration here, and make sure that this package always gets the 3.x driver. --- packages/connection-model/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/connection-model/package.json b/packages/connection-model/package.json index 3d04ca78322..7faaa6f0fb0 100644 --- a/packages/connection-model/package.json +++ b/packages/connection-model/package.json @@ -33,6 +33,7 @@ "async": "^3.1.0", "debug": "^4.1.1", "lodash": "^4.17.15", + "mongodb": "^3.6.3", "raf": "^3.4.1", "ssh2": "^0.8.7", "storage-mixin": "^4.1.0" @@ -46,7 +47,6 @@ "eslint-config-mongodb-js": "^5.0.3", "mocha": "^8.0.1", "mock-require": "^3.0.3", - "mongodb": "^3.6.3", "mongodb-runner": "^4.8.1", "proxyquire": "^2.1.0", "sinon": "^9.0.2", From 91da5d86f17770468c3bc8c3459a952620a221fe Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 16 Jun 2021 14:12:27 +0200 Subject: [PATCH 2/2] fixup --- packages/connection-model/package.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/connection-model/package.json b/packages/connection-model/package.json index 7faaa6f0fb0..c6a9909bb36 100644 --- a/packages/connection-model/package.json +++ b/packages/connection-model/package.json @@ -23,9 +23,6 @@ "test-ci": "npm run test", "posttest-ci": "node ../../scripts/killall-mongo.js" }, - "peerDependencies": { - "mongodb": "3.x" - }, "dependencies": { "@mongodb-js/ssh-tunnel": "^1.2.0", "ampersand-model": "^8.0.0",