From 9fbc7e2715c18efadee987bc6446cf241d865403 Mon Sep 17 00:00:00 2001 From: Sergey Petushkov Date: Fri, 20 Aug 2021 08:57:55 +0200 Subject: [PATCH] ci(evergreen): Remove the cygwin workaround for lint and disable verify step on windows --- .evergreen.yml | 4 +++- packages/compass-components/.eslintrc.js | 4 +--- packages/data-service/.eslintrc.js | 4 +--- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.evergreen.yml b/.evergreen.yml index 67eda7e04c4..2123c76f290 100644 --- a/.evergreen.yml +++ b/.evergreen.yml @@ -385,9 +385,11 @@ tasks: - func: install - func: verify + # We are skipping windows here because the way cygwin is setup breaks + # our lint configuration and doesn't allow `npm run check` to pass + variants: [macos, ubuntu, rhel] - func: test - variants: [macos, windows, ubuntu, rhel] vars: debug: 'hadron*,mongo*' diff --git a/packages/compass-components/.eslintrc.js b/packages/compass-components/.eslintrc.js index 29ad6baa080..e4cf824b6ac 100644 --- a/packages/compass-components/.eslintrc.js +++ b/packages/compass-components/.eslintrc.js @@ -3,8 +3,6 @@ module.exports = { extends: ['@mongodb-js/eslint-config-compass'], parserOptions: { tsconfigRootDir: __dirname, - // XXX: Workaround for https://github.com/nodejs/node/issues/34866 that - // supposedly "never getting fixed" - project: [require('path').resolve('tsconfig-lint.json')], + project: ['./tsconfig-lint.json'], }, }; diff --git a/packages/data-service/.eslintrc.js b/packages/data-service/.eslintrc.js index 29ad6baa080..e4cf824b6ac 100644 --- a/packages/data-service/.eslintrc.js +++ b/packages/data-service/.eslintrc.js @@ -3,8 +3,6 @@ module.exports = { extends: ['@mongodb-js/eslint-config-compass'], parserOptions: { tsconfigRootDir: __dirname, - // XXX: Workaround for https://github.com/nodejs/node/issues/34866 that - // supposedly "never getting fixed" - project: [require('path').resolve('tsconfig-lint.json')], + project: ['./tsconfig-lint.json'], }, };