From 949f1d01f5f5fc6fca7a50674812e72c2645666a Mon Sep 17 00:00:00 2001 From: Basit Date: Wed, 23 Feb 2022 17:25:29 +0100 Subject: [PATCH 1/2] fix(compass-components): pass correct index to itemKey --- packages/compass-components/src/components/virtual-grid.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/compass-components/src/components/virtual-grid.tsx b/packages/compass-components/src/components/virtual-grid.tsx index fe563f1ccc7..c07e9d2be5f 100644 --- a/packages/compass-components/src/components/virtual-grid.tsx +++ b/packages/compass-components/src/components/virtual-grid.tsx @@ -164,7 +164,7 @@ const Row: React.FunctionComponent<{ > ) : ( React.createElement(renderItem, { - key: itemKey?.(index) ?? index, + key: itemKey?.(cellIdx) ?? cellIdx, role: 'gridcell', className: cx(cell, classNames?.cell), tabIndex: itemIdx === currentTabbable ? 0 : -1, @@ -180,7 +180,6 @@ const Row: React.FunctionComponent<{ classNames?.cell, renderItem, itemKey, - index, currentTabbable, ]); From 6d34e407109f2fe59889f3b9af3b7504bc1818eb Mon Sep 17 00:00:00 2001 From: Basit Date: Wed, 23 Feb 2022 17:42:22 +0100 Subject: [PATCH 2/2] fix(compass-components): pass correct index to itemKey --- packages/compass-components/src/components/virtual-grid.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/compass-components/src/components/virtual-grid.tsx b/packages/compass-components/src/components/virtual-grid.tsx index c07e9d2be5f..413c1e79fc9 100644 --- a/packages/compass-components/src/components/virtual-grid.tsx +++ b/packages/compass-components/src/components/virtual-grid.tsx @@ -164,7 +164,7 @@ const Row: React.FunctionComponent<{ > ) : ( React.createElement(renderItem, { - key: itemKey?.(cellIdx) ?? cellIdx, + key: itemKey?.(itemIdx) ?? itemIdx, role: 'gridcell', className: cx(cell, classNames?.cell), tabIndex: itemIdx === currentTabbable ? 0 : -1,