From cf8f6e2acfbd2dc2dcc0798791523fade5f2e225 Mon Sep 17 00:00:00 2001 From: mcasimir Date: Thu, 10 Mar 2022 14:22:32 +0100 Subject: [PATCH] fix(connect-form): display warnings when a connection is selected --- .../connection-form/src/hooks/use-connect-form.ts | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/connection-form/src/hooks/use-connect-form.ts b/packages/connection-form/src/hooks/use-connect-form.ts index 84deb84d0d1..daf7937e26b 100644 --- a/packages/connection-form/src/hooks/use-connect-form.ts +++ b/packages/connection-form/src/hooks/use-connect-form.ts @@ -182,7 +182,7 @@ function buildStateFromConnectionInfo( enableEditingConnectionString: initialConnectionInfo.connectionOptions.connectionString === defaultConnectionString && !initialConnectionInfo.lastUsed, - warnings: errors + warnings: errors?.length ? [] : validateConnectionOptionsWarnings( initialConnectionInfo.connectionOptions @@ -550,12 +550,9 @@ export function useConnectForm( ...state, errors: [], // on each update the errors should reset ...updatedState, - warnings: - updatedState.errors && updatedState.errors.length > 0 - ? [] - : validateConnectionOptionsWarnings( - updatedState.connectionOptions - ), + warnings: updatedState.errors?.length + ? [] + : validateConnectionOptionsWarnings(updatedState.connectionOptions), isDirty: !isEqual( updatedState.connectionOptions, state.connectionOptions