From 61386d07c63bca1143ac5cd116b0e63c8e07e9e3 Mon Sep 17 00:00:00 2001 From: Lucas Hrabovsky Date: Wed, 16 Mar 2016 17:30:11 -0400 Subject: [PATCH 1/2] :bug: :checkered_flag: INT-1280 Fix sign_with_params typo --- scripts/config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/config.js b/scripts/config.js index 3e87fb4bb57..88968e43666 100755 --- a/scripts/config.js +++ b/scripts/config.js @@ -262,7 +262,7 @@ exports.get = function(cli, callback) { authors: CONFIG['version-string'].CompanyName, version: CONFIG['app-version'], exe: format('%s.exe', CONFIG.name), - signWithParams: CONFIG.signtool_params, + signWithParams: CONFIG.sign_with_params, loadingGif: CONFIG.loading_gif, title: CONFIG.name, productName: CONFIG.name, From 9951185feea4b2cc4aefbe5919b4868c0a9e7faf Mon Sep 17 00:00:00 2001 From: Matt Kangas Date: Fri, 18 Mar 2016 17:36:25 -0400 Subject: [PATCH 2/2] INT-1280 fix Windows signing Make the signtool.exe sitting in our current working directory executable. Remove the copy to electron-winstaller's vendor directory. In Squirrel.Windows/src/Update/Program.cs, function signPEFile: search order for "signtool.exe" is: - first: ".\signtool.exe" - second: GetExecutingAssembly().Location - "Run down PATH and hope for the best" source: https://github.com/Squirrel/Squirrel.Windows/blob/b814ada81a0060be22ec2f24efb6be0ff8c16d95/src/Update/Program.cs#L577-L588 --- .evergreen.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.evergreen.yml b/.evergreen.yml index f29bb1c9f62..f63f5a96d29 100644 --- a/.evergreen.yml +++ b/.evergreen.yml @@ -89,8 +89,7 @@ functions: -o "signtool.exe" \ --url "https://s3.amazonaws.com/boxes.10gen.com/build/signtool.exe" rm -f node_modules/electron-winstaller/vendor/signtool.exe - cp signtool.exe node_modules/electron-winstaller/vendor/signtool.exe - chmod +x node_modules/electron-winstaller/vendor/signtool.exe + chmod +x signtool.exe # Environment variables set for use by notary-service signtool.exe on Windows: # NOTARY_URL, NOTARY_AUTH_TOKEN, NOTARY_SIGNING_KEY, NOTARY_SIGNING_COMMENT