fix(crud): menu not fully showing for field actions, remove old backgrounds COMPASS-6186 #3574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, inherit border radius
Collaborator
|
Ditching the overflow hidden and the background makes sense to me, good call! Let's also remove the shadow, if we want them back we can re-add them later together with design. |
mcasimir
approved these changes
Oct 13, 2022
|
|
||
| .json-document-is-editing { | ||
| box-shadow: 2px 5px 8px fade(@palette__black, 20%); | ||
| border-radius: inherit; |
Collaborator
There was a problem hiding this comment.
nice trick, didn't know that we could have done this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-6186
Will remove the release notes label before merging as this isn't a released bug.
This PR fixes the menus not showing in the crud view. We're fixing it by removing the
overflow: nonein theKeylineCardcomponent. I think this is better than changing the menuusePortal={true}for now. Currently when an element that a portal is referring to is removed from the dom, the menu teleports to the top left while it collapses. We could work around this, but I thinkusePortal={false}is a cleaner approach.Did some drive by cleanup, removing old backgrounds.
Also added another 16px of margin to the bottom of the document list for a little better ux with the menus.
Because of these changes the previous box shadow on document cards being edited is now shown (it was hidden by the hidden overflow before). Do we want to remove this shadow? cc @mcasimir