chore(telemetry): update analytics-node to latest version COMPASS-7441 #5308
Conversation
| event: 'Telemetry Disabled', | ||
| properties: {}, | ||
| }); | ||
| void this._flushTelemetryAndIgnoreFailure(); |
There was a problem hiding this comment.
this can't be done anymore without closing the client
There was a problem hiding this comment.
Just making sure - does this mean that there is a chance that we might lose some telemetry that isn't synced yet? Probably not, right?
There was a problem hiding this comment.
That should be covered by the other flush, i think the reason this was here before is to "send telemetry one last time" and then stop sending anything after it has been disabled. I don't remember any strict requirement about this, I think that it should be fine to let the flush happen with a bit of delay here as long as we don't queue new events.
| event: 'Telemetry Disabled', | ||
| properties: {}, | ||
| }); | ||
| void this._flushTelemetryAndIgnoreFailure(); |
There was a problem hiding this comment.
Just making sure - does this mean that there is a chance that we might lose some telemetry that isn't synced yet? Probably not, right?
gribnoysup
changed the title
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes