feat(indexes): add an option to create indexes through rolling build COMPASS-8216 #6309
Conversation
| function isAtlasAPIError( | ||
| err: any | ||
| ): err is { error: number; errorCode: string; detail: string } { | ||
| return Boolean(err.error && err.errorCode && err.detail); | ||
| return Boolean(err && err.error && err.errorCode && err.detail); | ||
| } | ||
|
|
||
| function isCloudBackendError(err: any): err is { | ||
| errorCode: string; | ||
| message: string; | ||
| version: string; | ||
| status: string; | ||
| } { | ||
| return Boolean( | ||
| err && err.errorCode && err.message && err.version && err.status | ||
| ); |
There was a problem hiding this comment.
What is this second one? i.e. where do you get them from
There was a problem hiding this comment.
Sorry I only saw your comment now after I merged. I'm seeing similar code here: https://github.com/10gen/mms/blob/2ee6cb60d064e6eb4d3350d073cba947f1ae26f8/client/packages/components/Access/ServiceAccounts/utils.ts#L223-L232 for example. Don't know if that's related. But I can find results for both message and detail in the codebase.
Hopefully more a question than a review comment :)
lerouxb
left a comment
lerouxb
left a comment
There was a problem hiding this comment.
Approving and I'm going to merge. I'm aware that there's a delay between pressing the button and the rolling build showing up in the table, but I think it is best to try and deal with that (if at all) in a follow-up.
This patch adds the rolling index build support to compass (only available in compass-web when logged in to Atlas)