fix(compass-global-writes): try/catch and show error when global-writes fetch fails COMPASS-8333 #6408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djechlin-mongodb
force-pushed
the
COMPASS-8333
branch
from
7f55ec4 to
99aaf60
Compare
paula-stacho
reviewed
Nov 1, 2024
Collaborator
|
Looks good! Just one forgotten import :) Now that I'm reading it I was thinking if we should add message (and perhaps retry btn) to the UI, but that can be a follow up. |
Co-authored-by: Paula Stachova <paula.stachova@tutanota.com>
paula-stacho
approved these changes
Nov 7, 2024
Collaborator
paula-stacho
left a comment
paula-stacho
left a comment
There was a problem hiding this comment.
looks good! you just need to run npm run -w @mongodb-js/compass-global-writes reformat to fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
todo write the rest of the description
Checklist
Motivation and Context
Open Questions
n/a
Dependents
n/a
Types of changes