fix(e2e): account for a recurring MFA reminder when singing in to cloud ui #6429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
added
no release notes
Collaborator
Author
|
Merging to unblock CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't thought that this screen shows up over time after being dismissed, so the CI is currently failing because the sign in flow can't be finished. This patch adds a check for the dismiss button running in parallel to waiting for the auth request to resolve, so we either resolve when auth is done or this screen appears and we click the button and then wait for the auth
Unless you're trying this locally with your account it's kinda hard to repro for testing purposes, but I ran this tests twice locally against the account like that to make sure that 1) it's dismissed when appears 2) the code is not blocking the sign in when it doesn't appear, and both scenarios worked