Skip to content

Conversation

@gribnoysup
Copy link
Collaborator

Some small fixes for the global-writes tab conatiner:

  • WorkspaceContainer component should not be wrapped in anything, the intent is for it to always just take all the availble space in the tab, otherwise the shadow and scroll it renders looks weird and kinda broken
Before After
image image
  • Loading spinner was off-center because of the max width for the content it was rendered in, I also removed the vertical centering, we usually do a margin from the top (see CRUD for example) so that on bigger screens it's not showing up too close to the bottom, it looks a bit off and inconsistent with other tabs in the app
Before After
image image

@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 7, 2024
@gribnoysup gribnoysup merged commit 8585db7 into main Nov 7, 2024
27 of 29 checks passed
@gribnoysup gribnoysup deleted the global-writes-container-styles branch November 7, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants