chore(compass-connections): Move connection modal UI from compass-sidebar to compass-connections COMPASS-8471 #6508
Conversation
packages/compass-connections/src/stores/connections-store-redux.ts
Outdated
Show resolved
Hide resolved
|
|
||
| export default function WelcomeTab() { | ||
| const { createNewConnection } = useConnections(); | ||
| const { createNewConnection } = useConnectionActions(); |
There was a problem hiding this comment.
This one was a drive-by. I don't think there's any reason to use the deprecated useConnections() here.
lerouxb
changed the title
lerouxb
added
no release notes
| tab?: string | ||
| ): ConnectionsThunkAction<void> => { | ||
| return (_dispatch, _getState, { globalAppRegistry }) => { | ||
| globalAppRegistry.emit('open-compass-settings', tab); |
There was a problem hiding this comment.
To spare you the trouble: This is used by (probably among others) the text under the Use Application-Level Proxy Settings field in OIDC here:
| duplicateConnection, | ||
| saveEditedConnection, | ||
| toggleConnectionFavoritedStatus, | ||
| toggleFavoritedConnectionStatus, |
There was a problem hiding this comment.
was toggleConnectionFavoritedStatus in useConnections
| data-theme={darkMode ? 'Dark' : 'Light'} | ||
| > | ||
| <Home {...props}></Home> | ||
| <HomeWithConnections {...props}></HomeWithConnections> |
There was a problem hiding this comment.
Hierarchy is now ThemedHome -> HomeWithConnections -> Home whereas it was HomeWithConnections -> ThemedHome -> Home.
This allows CompassConnections to be inside all the visual stuff but still wrap the rest of home and therefore the useSingleConnectionModeConnectionInfoStatus() hook still works for now.
packages/compass-connections/src/components/connection-modal.tsx
Outdated
Show resolved
Hide resolved
No description provided.