fix(serverstats): update top chart write lock percentage of load visual COMPASS-8604 #6553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
changed the title
paula-stacho
approved these changes
Dec 13, 2024
Collaborator
paula-stacho
left a comment
paula-stacho
left a comment
There was a problem hiding this comment.
wow, good catch! this really needs a rewrite 🙈 I'd maybe even rename the variables to say 'Write' and 'Read' so that they're not that easy to confuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-8604
Small visual bug on how we show the % of write on the load in the top / hottest collections chart. Javascript related (typescript would catch this sort of thing).
Not easily seen which is probably why it's never been fixed. This bug has probably been in there since it was written 5+ years ago lol.
This is the chart for reference:
