Skip to content

Conversation

@lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Dec 9, 2024

These vars don't exist so they came through as blank strings.

See https://parsley.mongodb.com/evergreen/10gen_compass_main_package_macos_arm_package_compass_patch_95949cf2e090251f37a6a793c598e3101879c634_674f6a425ca1110007a29caa_24_12_03_20_29_56/0/task?bookmarks=0,2540,2542,7858&shareLine=2540

They are not part of default expansions: https://docs.devprod.prod.corp.mongodb.com/evergreen/Project-Configuration/Project-Configuration-Files#default-expansions

They are getting default values here

_.defaults(opts, { version: process.env.HADRON_APP_VERSION }, pkg, {
platform: process.platform,
arch: process.arch,
sign: true,
distribution,
});

@lerouxb lerouxb added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Dec 9, 2024
@lerouxb lerouxb merged commit c1a3119 into main Dec 9, 2024
31 checks passed
@lerouxb lerouxb deleted the remove-undefined-var-usage branch December 9, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants