fix(e2e): actually test the packaged app when running npm run test-packaged #6558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Dec 10, 2024
| export const context = parsedArgs as CommonParsedArgs & | ||
| Partial<DesktopParsedArgs & WebParsedArgs>; | ||
|
|
||
| debug('context:', context); |
Contributor
Author
There was a problem hiding this comment.
Handy for seeing if it actually picked up all the command-line args it should have.
Collaborator
There was a problem hiding this comment.
It's printed already a few lines down with secrets removed from the list:
const contextForPrinting = Object.fromEntries(
Object.entries(context).map(([k, v]) => {
return [k, /password/i.test(k) ? '<secret>' : v];
})
);
debug('Running tests with the following arguments:', contextForPrinting);
Is this print doing something different?
Contributor
Author
There was a problem hiding this comment.
Sorry didn't see it. We can remove it again.
lerouxb
added
the
no-title-validation
lerouxb
changed the title
lerouxb
changed the title
Anemy
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: This seems to only affect npm run test-packaged, not npm run test-packaged-ci which is what we run in CI. So it was fine in CI, just not locally. Depending on which command you run locally.
Since the refactor a couple of months ago we've been passing too many
--to the app and the arg parser was missing--test-packaged-appso it would re-build compass every time.You can test this by running the E2E tests against the locally installed beta, dev or GA like this: