feat(compass-web): add welcome page COMPASS-8657 #6593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Jan 8, 2025
| }); | ||
|
|
||
| function getCreateAtlasClusterUrl() { | ||
| return window.location.href.replace(/#.*$/, '#/clusters/starterTemplates'); |
Collaborator
There was a problem hiding this comment.
You can just do #/clusters/starterTemplates here, you don't need a full url to replace a fragment
Collaborator
Author
There was a problem hiding this comment.
i also removed more code in f44ae52 to fix the test failures
gribnoysup
approved these changes
Jan 8, 2025
Collaborator
gribnoysup
left a comment
gribnoysup
left a comment
There was a problem hiding this comment.
Neat! Thanks for the cleanup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we added CompassWeb specific welcome page. compass-welcome plugin exports two different welcome tabs (web and desktop).
For
connections-store-reduxchanges, currently we have code that supports single connection and as such when connection form is not visible, we still have a connection in the store. For renderingCreate Clusterbutton for web, we check if there's no cluster (connection) and show the button. To avoid doingif count is numConnections - 1, I removed this initial part from connections-store-redux.Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes