From b41e159360e15c57f053bd5f19b523cb27a0dde6 Mon Sep 17 00:00:00 2001 From: Basit Chonka Date: Tue, 17 Jun 2025 16:32:32 +0200 Subject: [PATCH 1/3] enable web tests --- packages/compass-e2e-tests/tests/data-modeling-tab.test.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/compass-e2e-tests/tests/data-modeling-tab.test.ts b/packages/compass-e2e-tests/tests/data-modeling-tab.test.ts index 3ded8ff12d0..d4395ff7465 100644 --- a/packages/compass-e2e-tests/tests/data-modeling-tab.test.ts +++ b/packages/compass-e2e-tests/tests/data-modeling-tab.test.ts @@ -26,8 +26,6 @@ describe('Data Modeling tab', function () { let browser: CompassBrowser; before(async function () { - skipForWeb(this, 'data modeling not yet available in compass-web'); - compass = await init(this.test?.fullTitle()); browser = compass.browser; await browser.setFeature('enableDataModeling', true); From fa831d1178548c3e72b18579e6aa2a3d304081e8 Mon Sep 17 00:00:00 2001 From: Basit Chonka Date: Thu, 19 Jun 2025 15:02:43 +0200 Subject: [PATCH 2/3] make flag writable on web --- packages/compass-e2e-tests/helpers/test-runner-context.ts | 2 +- packages/compass-e2e-tests/tests/data-modeling-tab.test.ts | 3 +-- .../src/compass-web-preferences-access.ts | 1 + 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/compass-e2e-tests/helpers/test-runner-context.ts b/packages/compass-e2e-tests/helpers/test-runner-context.ts index b05e059ba32..277809458c2 100644 --- a/packages/compass-e2e-tests/helpers/test-runner-context.ts +++ b/packages/compass-e2e-tests/helpers/test-runner-context.ts @@ -344,7 +344,7 @@ process.env.HADRON_DISTRIBUTION ??= context.hadronDistribution; process.env.COMPASS_WEB_HTTP_PROXY_CLOUD_CONFIG ??= context.atlasCloudSandboxCloudConfig ?? 'dev'; -if (isTestingAtlasCloudSandbox(context)) { +if (isTestingAtlasCloudSandbox(context) || isTestingWeb()) { process.env.E2E_TEST_CLOUD_WEB_ENABLE_PREFERENCE_SAVING ??= 'true'; } diff --git a/packages/compass-e2e-tests/tests/data-modeling-tab.test.ts b/packages/compass-e2e-tests/tests/data-modeling-tab.test.ts index 721f5395f54..5789ca11e1e 100644 --- a/packages/compass-e2e-tests/tests/data-modeling-tab.test.ts +++ b/packages/compass-e2e-tests/tests/data-modeling-tab.test.ts @@ -4,7 +4,6 @@ import { init, cleanup, screenshotIfFailed, - skipForWeb, DEFAULT_CONNECTION_NAME_1, } from '../helpers/compass'; import type { Compass } from '../helpers/compass'; @@ -40,8 +39,8 @@ describe('Data Modeling tab', function () { before(async function () { compass = await init(this.test?.fullTitle()); browser = compass.browser; - await browser.setFeature('enableDataModeling', true); await browser.setupDefaultConnections(); + await browser.setFeature('enableDataModeling', true); }); beforeEach(async function () { diff --git a/packages/compass-preferences-model/src/compass-web-preferences-access.ts b/packages/compass-preferences-model/src/compass-web-preferences-access.ts index 3ae73b24e8f..259390ea180 100644 --- a/packages/compass-preferences-model/src/compass-web-preferences-access.ts +++ b/packages/compass-preferences-model/src/compass-web-preferences-access.ts @@ -17,6 +17,7 @@ const editablePreferences: (keyof UserPreferences)[] = [ 'enableGenAISampleDocumentPassingOnAtlasProject', 'enableGenAIFeaturesAtlasOrg', 'enableGenAIFeaturesAtlasProject', + 'enableDataModeling', ]; export class CompassWebPreferencesAccess implements PreferencesAccess { From 93025173fed1ba16bca6749510bd32e6a55ce419 Mon Sep 17 00:00:00 2001 From: Basit Chonka Date: Thu, 19 Jun 2025 15:32:38 +0200 Subject: [PATCH 3/3] cleaner check --- packages/compass-e2e-tests/helpers/test-runner-context.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/compass-e2e-tests/helpers/test-runner-context.ts b/packages/compass-e2e-tests/helpers/test-runner-context.ts index 277809458c2..c76b592b38b 100644 --- a/packages/compass-e2e-tests/helpers/test-runner-context.ts +++ b/packages/compass-e2e-tests/helpers/test-runner-context.ts @@ -344,7 +344,7 @@ process.env.HADRON_DISTRIBUTION ??= context.hadronDistribution; process.env.COMPASS_WEB_HTTP_PROXY_CLOUD_CONFIG ??= context.atlasCloudSandboxCloudConfig ?? 'dev'; -if (isTestingAtlasCloudSandbox(context) || isTestingWeb()) { +if (isTestingWeb()) { process.env.E2E_TEST_CLOUD_WEB_ENABLE_PREFERENCE_SAVING ??= 'true'; }