Skip to content

Conversation

@mabaasit
Copy link
Collaborator

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mabaasit mabaasit marked this pull request as ready for review September 30, 2025 08:12
@mabaasit mabaasit requested a review from a team as a code owner September 30, 2025 08:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates test suites and the end-of-life server version configuration to remove server version checks that are no longer needed, likely because support for older MongoDB server versions has been dropped.

  • Removes server version checks from multiple e2e test files that were skipping tests for older server versions
  • Updates the fallback end-of-life server version from '4.4' to '6.x'
  • Updates corresponding test expectations to reflect the new end-of-life version threshold

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/compass-e2e-tests/tests/search-indexes.test.ts Removes server version check for >= 4.1.11 and unused import
packages/compass-e2e-tests/tests/database-collections-tab.test.ts Removes server version checks for time series and clustered collections
packages/compass-e2e-tests/tests/collection-indexes-tab.test.ts Removes server version checks and describe blocks for wildcard and hide/unhide index features
packages/compass-e2e-tests/tests/collection-import.test.ts Removes server version checks for validation error details and unused import
packages/compass-e2e-tests/tests/collection-documents-tab.test.ts Removes server version check for validation features and unused import
packages/compass-e2e-tests/tests/collection-aggregations-tab.test.ts Removes numerous server version checks and consolidates aggregation operator expectations
packages/compass-connections/src/utils/end-of-life-server.ts Updates fallback end-of-life server version from '4.4' to '6.x'
packages/compass-connections/src/utils/end-of-life-server.spec.ts Updates test expectations to reflect new end-of-life version threshold

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mabaasit mabaasit merged commit ec67b8e into main Sep 30, 2025
84 of 85 checks passed
@mabaasit mabaasit deleted the COMPASS-9909-update-fallback-eol-server branch September 30, 2025 08:53
@kraenhansen
Copy link
Contributor

LGTM (for what it's worth 🙂)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants