From 8b51aebc593b2875a4c0236cd1c3855c7ae55b42 Mon Sep 17 00:00:00 2001 From: Le Roux Bodenstein Date: Wed, 12 Nov 2025 09:51:44 +0000 Subject: [PATCH] disable dropping database in readonly in the context menu --- .../src/connections-navigation-tree.spec.tsx | 11 +++++++---- .../src/item-actions.ts | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/compass-connections-navigation/src/connections-navigation-tree.spec.tsx b/packages/compass-connections-navigation/src/connections-navigation-tree.spec.tsx index 71b99e5de88..e74db73a04a 100644 --- a/packages/compass-connections-navigation/src/connections-navigation-tree.spec.tsx +++ b/packages/compass-connections-navigation/src/connections-navigation-tree.spec.tsx @@ -1064,10 +1064,13 @@ describe('ConnectionsNavigationTree', function () { const contextMenu = screen.getByTestId('context-menu'); // Check that write actions are not present in read-only mode - expect(() => within(contextMenu).getByText('Create collection')).to - .throw; - expect(() => within(contextMenu).getByText('Create database')).to.throw; - expect(() => within(contextMenu).getByText('Drop database')).to.throw; + expect(() => + within(contextMenu).getByText('Create collection') + ).to.throw(); + expect(() => + within(contextMenu).getByText('Create database') + ).to.throw(); + expect(() => within(contextMenu).getByText('Drop database')).to.throw(); // Check that read-only actions are still present expect(within(contextMenu).getByText('View performance metrics')).to.be diff --git a/packages/compass-connections-navigation/src/item-actions.ts b/packages/compass-connections-navigation/src/item-actions.ts index 3a303140b4c..3d5867677cd 100644 --- a/packages/compass-connections-navigation/src/item-actions.ts +++ b/packages/compass-connections-navigation/src/item-actions.ts @@ -379,7 +379,7 @@ export const databaseContextMenuActions = ({ icon: 'Plus', label: 'Create database', }, - hasWriteActionsDisabled && canDeleteDatabase + hasWriteActionsDisabled || !canDeleteDatabase ? null : { action: 'drop-database',