chore: make private deps of data-service public #7593
Conversation
lerouxb
added
the
no-title-validation
There was a problem hiding this comment.
Pull request overview
This PR makes three internal packages public by replacing the "private": true field with publishConfig settings. This change is necessary because these packages are transitive dependencies of the VS Code extension that were inadvertently made private in a previous refactoring.
- Removes private flag from compass-utils, compass-logging, and compass-app-registry
- Adds publishConfig with public access to enable npm publishing
- Corrects dependency visibility for VS Code extension compatibility
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/compass-utils/package.json | Changed from private to public with publishConfig |
| packages/compass-logging/package.json | Changed from private to public with publishConfig |
| packages/compass-app-registry/package.json | Changed from private to public with publishConfig |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "publishConfig": { | ||
| "access": "public" | ||
| }, |
There was a problem hiding this comment.
Can you give an example where it's pulled as transitive for other public packges? We should probably remove this dependency
There was a problem hiding this comment.
There was a problem hiding this comment.
Actually, I guess it's weird that DataService depends on compass-logging and not on something lower level like mongodb log writer (I'm sure I said something exactly opposite at some point 🙂). I'll open a ticket for that
There was a problem hiding this comment.
gribnoysup
left a comment
gribnoysup
left a comment
There was a problem hiding this comment.
Good as a temp workaround, but I opened https://jira.mongodb.org/browse/COMPASS-10116 to follow-up
We missed some transitive deps of things the vscode extension depend on when we made a bunch of packages private recently.