Skip to content

chore: make private deps of data-service public #7593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

chore: make private deps of data-service public #7593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/compass-app-registry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
"url": "https://jira.mongodb.org/projects/COMPASS/issues",
"email": "compass@mongodb.com"
},
"private": true,
"publishConfig": {
"access": "public"
},
Comment on lines +12 to +14
Copy link
Collaborator

@gribnoysup gribnoysup Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give an example where it's pulled as transitive for other public packges? We should probably remove this dependency

Copy link
Contributor Author

@lerouxb lerouxb Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compass/packages/compass-logging/package.json

Line 56 in ede0046

"@mongodb-js/compass-app-registry": "^9.4.28",

Copy link
Collaborator

@gribnoysup gribnoysup Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le Roux Bodenstein
11:26

compass/packages/compass-logging/package.json

Line 56 in ede0046

"@mongodb-js/compass-app-registry": "^9.4.28",

Copy link
Collaborator

@gribnoysup gribnoysup Nov 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I guess it's weird that DataService depends on compass-logging and not on something lower level like mongodb log writer (I'm sure I said something exactly opposite at some point 🙂). I'll open a ticket for that

Copy link
Contributor Author

@lerouxb lerouxb Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compass/packages/compass-logging/src/provider.ts

Line 7 in ede0046

import { createServiceLocator } from '@mongodb-js/compass-app-registry';

Copy link
Collaborator

@addaleax addaleax Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems easy enough: #7595

"homepage": "https://github.com/mongodb-js/compass",
"version": "9.4.28",
"repository": {
Expand Down
4 changes: 3 additions & 1 deletion packages/compass-logging/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
"name": "MongoDB Inc",
"email": "compass@mongodb.com"
},
"private": true,
"publishConfig": {
"access": "public"
},
"bugs": {
"url": "https://jira.mongodb.org/projects/COMPASS/issues",
"email": "compass@mongodb.com"
Expand Down
4 changes: 3 additions & 1 deletion packages/compass-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
"name": "MongoDB Inc",
"email": "compass@mongodb.com"
},
"private": true,
"publishConfig": {
"access": "public"
},
"bugs": {
"url": "https://jira.mongodb.org/projects/COMPASS/issues",
"email": "compass@mongodb.com"
Expand Down
Loading