Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
8bd985f
Upgrade LG modal packages
kraenhansen Nov 25, 2025
aafba5a
Fix Modal to adopt LG Modal v20
kraenhansen Sep 30, 2025
7fd2377
Fix connection-form to work around LG Modal v20
kraenhansen Sep 30, 2025
4fab8b7
Update generative-ai to adopt marketing-modal v7
kraenhansen Sep 30, 2025
b3c08ef
Fix compass-import-export to work around LG modal v20
kraenhansen Sep 30, 2025
4d5f356
Update compass-welcome to adopt marketing-modal v7
kraenhansen Nov 5, 2025
5d909fe
Update compass-explain-plan to LG Modal v20
kraenhansen Oct 1, 2025
40bc47d
Fix compass-crud to adopt LG modal v20
kraenhansen Oct 1, 2025
df410fc
Update compass-schema to LG Modal v20
kraenhansen Oct 1, 2025
2141269
Add workaround for jsdom missing HTMLDialogElement support
kraenhansen Oct 2, 2025
642d64d
Update generative-ai to adopt LG modal v20
kraenhansen Oct 7, 2025
2d2649b
Fix fullScreen prop on derived Modal
kraenhansen Oct 7, 2025
70f7b32
Remove use of deprecated backdropClassName
kraenhansen Oct 7, 2025
db7e550
Remove workaround for MarketingModal button disabling
kraenhansen Oct 7, 2025
265b634
Fix remaining components tests
kraenhansen Oct 7, 2025
bf23395
Revert workaround for LG-5593
kraenhansen Oct 8, 2025
33c1940
Update existing tests to handle dialog elements remaining in the DOM
kraenhansen Nov 5, 2025
d9ee067
Update databases-collections to allow immediate removal of the heading
kraenhansen Nov 6, 2025
7b86998
Update e2e tests to use waitForDisplayed over waitForExist as this is…
kraenhansen Nov 6, 2025
b4bd082
Update e2e tests removing [role=dialog] from confirm dialog selectors
kraenhansen Nov 7, 2025
9455ac2
Update e2e tests to wait for bulk delete modal to disappear
kraenhansen Nov 7, 2025
703451e
Update e2e tests to wait for connection form to be non-clickable in a…
kraenhansen Nov 7, 2025
ae8d9a9
Update e2e tests to fix modal regressions
kraenhansen Nov 21, 2025
36dec3c
Disable pointer events on a closed modal
kraenhansen Nov 10, 2025
10833e4
Disable auto-focus on confirmation modal children by default
kraenhansen Nov 10, 2025
4b3acd9
Add new modal specific commands
kraenhansen Nov 11, 2025
b56ff8e
Update E2E tests to use new modal commands instead of waitForDisplayed
kraenhansen Nov 11, 2025
91ac1f2
Default initialFocus to "null" to avoid breaking existing modals
kraenhansen Nov 12, 2025
20e7c93
Wait for confirm button to show instead of simply expecting it
kraenhansen Nov 17, 2025
000f94a
Update FocusMode tests to handle LG Modal v20
kraenhansen Nov 25, 2025
aff726d
Update SettingsModal tests to handle LG Modal v20
kraenhansen Nov 25, 2025
60d454d
Clarify disabling the @typescript-eslint/no-namespace and add a TODO …
kraenhansen Nov 26, 2025
a8bf853
Partial revert of ddd6d70dd59fbe8f948ea6e5ef80b6d478bc1eff
kraenhansen Nov 26, 2025
6e77659
Fix auto-focus in bulk update and delete modals
kraenhansen Dec 1, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,25 @@ Object.assign(tabbable, {
origTabbable.isTabbable(node, { ...options, displayCheck: 'none' }),
});

// Workaround for missing HTMLDialogElement in jsdom
// See https://github.com/jsdom/jsdom/issues/3294

Object.assign(HTMLDialogElement.prototype, {
show() {
this.open = true;
this.style.display = '';
},
showModal() {
this.open = true;
this.style.display = '';
},
close(returnValue) {
this.open = false;
this.returnValue = returnValue;
this.style.display = 'none';
},
});

// leafygreen (through `clipboard` library) uses deprecated API check that is
// not working in jsdom if copy / paste APIs are supported
if (!window.document.queryCommandSupported) {
Expand Down
43 changes: 43 additions & 0 deletions configs/testing-library-compass/src/assertions.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import { Assertion, util } from 'chai';

// TODO(COMPASS-10119): Move declaration into a separate .d.ts and implementation into a *-register.js file as we do with other global patching code intended for tests.

declare global {
// eslint-disable-next-line @typescript-eslint/no-namespace -- We're following a pattern established in the `@types/chai-as-promised` package to add a Chai assertion property.
export namespace Chai {
interface Assertion {
/** Asserts that a dialog is open */
get open(): Assertion;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anemy FYI for the eslint plugin you are working on in devtools-shared, new terminator assertion

/** Asserts that a dialog is closed */
get closed(): Assertion;
}
}
}

util.addProperty(
Assertion.prototype,
'open',
function (this: typeof Assertion) {
const obj = util.flag(this, 'object');
new Assertion(obj).to.be.instanceof(HTMLDialogElement);
new Assertion(obj as HTMLDialogElement).has.property(
'open',
true,
'Expected dialog to be open'
);
}
);

util.addProperty(
Assertion.prototype,
'closed',
function (this: typeof Assertion) {
const obj = util.flag(this, 'object');
new Assertion(obj).to.be.instanceof(HTMLDialogElement);
new Assertion(obj as HTMLDialogElement).has.property(
'open',
false,
'Expected dialog to be closed'
);
}
);
2 changes: 2 additions & 0 deletions configs/testing-library-compass/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ import { expect } from 'chai';
import { Provider } from 'react-redux';
import ConnectionString from 'mongodb-connection-string-url';

import './assertions';

function wait(ms: number) {
return new Promise((resolve) => {
setTimeout(resolve, ms);
Expand Down
Loading
Loading