chore(components): delete unused ContentWithFallback and FadeInPlaceholder components
#7615
+0
−298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
the
no-title-validation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unused React components (ContentWithFallback and FadeInPlaceholder) that are no longer needed in the codebase, as these have been superseded by modern React Suspense boundaries.
- Removed exports for
ContentWithFallbackandFadeInPlaceholderfrom the package index - Deleted the implementation file containing both components
- Deleted the associated test file
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/compass-components/src/index.ts | Removed exports for the two unused components |
| packages/compass-components/src/components/content-with-fallback.tsx | Deleted entire component implementation file |
| packages/compass-components/src/components/content-with-fallback.spec.tsx | Deleted test file for the removed components |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
13 tasks
|
Assigned |
Anemy
approved these changes
Nov 28, 2025
Anemy
changed the title
ContentWithFallback and FadeInPlaceholder componentsContentWithFallback and FadeInPlaceholder components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per #7594 (comment) these two components aren't used anymore and updating their tests are turning a bit messy - dropping them entirely seem like the best option.
Also - a React suspense boundary seems like a good modern alternative.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes