From 496c8b097acf9466786fc65b14126b0975ff5570 Mon Sep 17 00:00:00 2001 From: Durran Jordan Date: Thu, 2 Mar 2017 15:27:15 +0100 Subject: [PATCH 1/2] COMPASS-532: Don't use pseudo selectors for strings --- package.json | 2 +- src/internal-packages/crud/styles/element.less | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/package.json b/package.json index 94ccd74cd76..0f29ffaeef4 100644 --- a/package.json +++ b/package.json @@ -136,7 +136,7 @@ "hadron-ipc": "^0.0.7", "hadron-module-cache": "^0.0.3", "hadron-package-manager": "0.2.0", - "hadron-react-bson": "^0.0.2", + "hadron-react-bson": "^0.3.0", "hadron-react-buttons": "^0.2.0", "hadron-reflux-store": "^0.0.2", "hadron-style-manager": "0.0.1", diff --git a/src/internal-packages/crud/styles/element.less b/src/internal-packages/crud/styles/element.less index 5e6d268c436..cb6477e56d1 100644 --- a/src/internal-packages/crud/styles/element.less +++ b/src/internal-packages/crud/styles/element.less @@ -26,12 +26,6 @@ color: steelblue; white-space: pre-line; word-break: break-all; - &::before { - content: "\""; - } - &::after { - content: "\""; - } } &-is-int32 { From 72d17e144e312ecebecfa45a7783b0b3900bcf1d Mon Sep 17 00:00:00 2001 From: Durran Jordan Date: Thu, 2 Mar 2017 15:44:55 +0100 Subject: [PATCH 2/2] Fix functional tests with quotes in strings --- test/functional/compass-functional.test.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/functional/compass-functional.test.js b/test/functional/compass-functional.test.js index a2f1c844961..57f648c838b 100644 --- a/test/functional/compass-functional.test.js +++ b/test/functional/compass-functional.test.js @@ -539,7 +539,7 @@ describe('Compass Main Functional Test Suite #spectron', function() { .clickInsertDocumentModalButton() .waitForDocumentInsert(1) .getDocumentValues(1) - .should.eventually.include('Aphex Twin'); + .should.eventually.include('\"Aphex Twin\"'); }); }); @@ -569,7 +569,7 @@ describe('Compass Main Functional Test Suite #spectron', function() { .clickUpdateDocumentButton(1) .waitForDocumentUpdate(1) .getDocumentValues(1) - .should.eventually.include('Aphex Twin (edited)'); + .should.eventually.include('\"Aphex Twin (edited)\"'); }); }); @@ -582,7 +582,7 @@ describe('Compass Main Functional Test Suite #spectron', function() { .clickInsertDocumentModalButton() .waitForDocumentInsert(2) .getDocumentValues(2) - .should.eventually.include('Essex'); + .should.eventually.include('\"Essex\"'); }); }); @@ -854,7 +854,7 @@ describe('Compass Main Functional Test Suite #spectron', function() { .clickResetFilterButtonFromDocumentsTab() .waitForStatusBar() .getDocumentValues(3) - .should.eventually.include('George Michael'); + .should.eventually.include('\"George Michael\"'); }); }); });