test: add rebuild step to webpack bundling example #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Adds a build step for the local Webpack bundling test.
In the current setup, the
buildfolder is not included in the tarball created bynpm pack(as npm ignores it by default). Consequently, the prebuild-install step fails to find a prebuilt binary, and the package must be built from source after installation. This PR adds the explicit npm rebuild step to the test script.As a result, the Webpack build now succeeds but still shows a warning:
This remaining warning is expected. It is due to Webpack's static analysis of the
util.jsfile, which includes a fallback require for a Debug build (which does not exist in our production build).Notes for Reviewers
Reviewers can follow the instructions inside test/bundling/webpack folder and then run node
dist/main.jsto see kerberos working:What is the motivation for this change?
During a routine update of the dependencies, I discovered this test was broken.
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript