Skip to content

chore: skip atlas tests in mongodb forks #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2025
Merged

chore: skip atlas tests in mongodb forks #707

merged 2 commits into from
Oct 31, 2025

Conversation

@blva
Copy link
Collaborator

@blva blva commented Oct 29, 2025 •
edited
Loading

Proposed changes

  • dependabot prs were failing because we were not properly skipping local tests

Checklist

@blva blva marked this pull request as ready for review October 29, 2025 15:10
@blva blva requested a review from a team as a code owner October 29, 2025 15:10
Copilot AI review requested due to automatic review settings October 29, 2025 15:10
Copilot AI reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a CI issue where Dependabot pull requests were failing in MongoDB forks due to Atlas tests not being properly skipped.

  • Adds environment variables to skip Atlas tests in the fork workflow

@blva
Update .github/workflows/code-health-fork.yml
94d109e 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@gagik
Copy link
Collaborator

gagik commented Oct 30, 2025

Come to think of it: should we skip these tests or just require manual approval for them? I imagine some dep updates might be entirely about Atlas-related stuff

@blva
Copy link
Collaborator Author

blva commented Oct 31, 2025

Come to think of it: should we skip these tests or just require manual approval for them? I imagine some dep updates might be entirely about Atlas-related stuff

I can check if that's not already supported and add as a follow-up, want to clean up our dependabot PRs first

@blva blva merged commit 2b203a1 into main Oct 31, 2025
16 of 18 checks passed
@blva blva deleted the gh-action-fork branch October 31, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@gagik gagik gagik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blva @gagik