chore: error on invalid schema passed to headers and query parameters #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error handling for invalid configuration values passed via headers and query parameters. Instead of silently ignoring malformed values, the system now throws explicit errors when values fail schema validation.
Key changes:
- Enhanced
parseConfigValuefunction to throw detailed error messages when schema validation fails - Updated test cases to verify the new error-throwing behavior instead of silent fallback to defaults
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/common/config/configOverrides.ts | Modified parseConfigValue to throw validation errors instead of returning undefined |
| tests/unit/common/config/configOverrides.test.ts | Updated test expectations to verify error throwing behavior and removed an unused test line |
himanshusinghs
approved these changes
Nov 26, 2025
Collaborator
Pull Request Test Coverage Report for Build 19711018550Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @himanshusinghs for catching this; it'd be better to error instead of ignoring these fields.