From d6106d1ef058ea4734a817c4727fe153a7581a56 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Mon, 10 Jan 2022 11:47:11 +0100 Subject: [PATCH] Revert "chore(build): skip attempted PGP signing for now (#1174)" This reverts commit 01997aba3b8e001c8668656731e12d491972756a. --- packages/build/src/run-draft.spec.ts | 8 +++----- packages/build/src/run-draft.ts | 6 +----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/packages/build/src/run-draft.spec.ts b/packages/build/src/run-draft.spec.ts index 9d9a213652..fb8a24dd7b 100644 --- a/packages/build/src/run-draft.spec.ts +++ b/packages/build/src/run-draft.spec.ts @@ -68,17 +68,15 @@ describe('draft', () => { }); it('asks the notary service to sign files', () => { - // expect(notarizeArtifact).to.have.been.callCount(ALL_BUILD_VARIANTS.length); + expect(notarizeArtifact).to.have.been.callCount(ALL_BUILD_VARIANTS.length); }); it('uploads artifacts to download center', () => { - expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length); - // expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2); + expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2); }); it('uploads the artifacts to the github release', () => { - expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length); - // expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2); + expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2); }); }); diff --git a/packages/build/src/run-draft.ts b/packages/build/src/run-draft.ts index dcb731828e..15a339f267 100644 --- a/packages/build/src/run-draft.ts +++ b/packages/build/src/run-draft.ts @@ -44,8 +44,6 @@ export async function runDraft( tmpDir ); - /* - // pending https://jira.mongodb.org/browse/BUILD-14385 await notarizeArtifact( tarballFile.path, { @@ -55,12 +53,10 @@ export async function runDraft( } ); const signatureFile = tarballFile.path + '.sig'; - */ - void notarizeArtifact; await Promise.all([ [ downloadedArtifact, tarballFile.contentType ], - // [ signatureFile, 'application/pgp-signature' ] + [ signatureFile, 'application/pgp-signature' ] ].flatMap(([ path, contentType ]) => [ uploadToDownloadCenter( path,